Closed quant-ranger[bot] closed 2 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 93.36%. Comparing base (
a0ec606
) to head (97b8bc0
). Report is 1 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@kklein I'm not sure about the following update
sqlalchemy 1.4.49 2.0.32 Major Upgrade snowflake-py38 on all platforms
As far as I remember, the snowflake connector had issues with sqlalchemy 2.0. Or am I wrong? Or maybe now it got fixed?
@ivergara Good catch! This used to cause problems.
A somewhat recent release of snowflake-sqlalchemy
brought compatibility with sqlalchemy >= 2.0
: https://github.com/snowflakedb/snowflake-sqlalchemy/releases/tag/v1.6.1
This is also reflected in its dependencies: https://github.com/snowflakedb/snowflake-sqlalchemy/blob/fd8c29a08696feab256d51fc2c42773cfd74c590/pyproject.toml#L41 https://github.com/conda-forge/snowflake-sqlalchemy-feedstock/blob/e7cbfa290a2da0f1ad27954461c432aa44b43955/recipe/meta.yaml#L25
Since our snowflake tests also run through, I would think that upgrading the sqlalchemy
version we use to test against snowflake should be fine.
What are your thoughts?
I'm fine going to SA2 then. No one should be using 1.4. unless compatibility issues like the one we were facing.
Now the question is whether we want to have individual tests for snowflake with sa1 and sa2 or we keep only sa2. In any case, the wording of the label of the current snowflake test should be amended. I'm of the opinion we get rid of SA1.
Explicit dependencies
db2-sa1 on {linux-64, win-64}
Implicit dependencies
{db2-py310, db2-py38, db2-py39, db2-sa1, lint} on {linux-64, osx-arm64}
{bigquery-py38, bigquery-sa1} on all platforms
{db2-py39, mssql-py39, postgres-py39, py39} on {linux-64, win-64}
db2-sa1 on {linux-64, win-64}
db2-sa1 on osx-arm64
[^1]: Bold means explicit dependency. [^2]: Dependency got downgraded.