Quantco / metalearners

MetaLearners for CATE estimation
https://metalearners.readthedocs.io/en/latest/
BSD 3-Clause "New" or "Revised" License
34 stars 4 forks source link

Fix index columns order for `MetaLearnerGridSearch.results_` #58

Closed FrancescMartiEscofetQC closed 4 months ago

FrancescMartiEscofetQC commented 4 months ago

Solves #47 The columns order now is first "metalearner", then all the nuisance models with their parameters and finally the treatment models with their parameters.

Example

Checklist

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 94.94%. Comparing base (f8c0db7) to head (f79658a). Report is 32 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #58 +/- ## ========================================== + Coverage 94.91% 94.94% +0.03% ========================================== Files 15 15 Lines 1476 1485 +9 ========================================== + Hits 1401 1410 +9 Misses 75 75 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

kklein commented 4 months ago

@FrancescMartiEscofetQC Thanks for working on this :)

Would you mind adding a test case that would've failed before and won't fail anymore based on this bug fix?

FrancescMartiEscofetQC commented 4 months ago

Would you mind adding a test case that would've failed before and won't fail anymore based on this bug fix?

Sure! 51a5faf