Quantco / metalearners

MetaLearners for CATE estimation
https://metalearners.readthedocs.io/en/latest/
BSD 3-Clause "New" or "Revised" License
34 stars 4 forks source link

Rename `indices` to `mask`. Closes issue #91 #92

Closed kyracho closed 2 months ago

kyracho commented 2 months ago

Checklist

Hi, this PR changes _treatment_variants_indices to _treatment_variants_indices in

Closes issue #91

kyracho commented 2 months ago

Hello, I apologize for the multiple commits and any confusion this may have caused. I was working through some issues and ended up with a bit of a messy commit history. I made the mistake of forgetting to build the documentation locally, and it took several commits to rename all occurrences of the internal variable. The force-push was to amend a typo in the last commit message... embarrassing! I appreciate your understanding, and I’ll be more mindful in the future to keep things cleaner and more concise.

kklein commented 2 months ago

Hi Kyra - thanks a lot for your contribution - this looks great! :)

I'd have two small asks:

kyracho commented 2 months ago

Hi kklein, no problem at all regarding the changes—I'll go ahead and remove the changelog entry for version 0.12.0 as well as the files checked into docs/api. Thank you for clarifying.