Closed kyracho closed 2 months ago
Hello, I apologize for the multiple commits and any confusion this may have caused. I was working through some issues and ended up with a bit of a messy commit history. I made the mistake of forgetting to build the documentation locally, and it took several commits to rename all occurrences of the internal variable. The force-push was to amend a typo in the last commit message... embarrassing! I appreciate your understanding, and I’ll be more mindful in the future to keep things cleaner and more concise.
Hi Kyra - thanks a lot for your contribution - this looks great! :)
I'd have two small asks:
_
prefix, fields, we wouldn't consider it an user-facing change. We generally only try to document user-facing changes in the changelog. Apologies that this wasn't clearer - I'll update the PR template.docs/api
? These are usually auto-generated and not version-controlled by us.
Hi kklein, no problem at all regarding the changes—I'll go ahead and remove the changelog entry for version 0.12.0 as well as the files checked into docs/api. Thank you for clarifying.
Checklist
Hi, this PR changes
_treatment_variants_indices
to_treatment_variants_indices
inmetalearner.py
xlearner.py
tlearner.py
drlearner.py
test_learner.py
Closes issue #91
CHANGELOG.rst
entry