Fix definitions of symmetric a_plus/a_min

QuantumKitHub / MPSKitModels.jl

MIT License

15 stars 13 forks source link

Fix definitions of symmetric a_plus/a_min #8

Closed 20akshay00 closed 7 months ago

20akshay00 commented 8 months ago

The operators a_plus and a_min conventionally correspond to the raising/creation operator (a_dag) and lowering/annihilation operator (a). The definitions for the symmetric versions are currently swapped and this PR fixes that. Trivial case seems fine as is.

lkdvos commented 7 months ago

Looks great, I'll merge once tests turn green, thanks!

codecov[bot] commented 7 months ago

Welcome to Codecov :tada:

Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment.

Thanks for integrating Codecov - We've got you covered :open_umbrella: