QuantumKitHub / MPSKitModels.jl

MIT License
15 stars 13 forks source link

Add missing terms in Bose Hubbard hamiltonian #9

Closed 20akshay00 closed 7 months ago

20akshay00 commented 7 months ago

Current implementation runs through nearest neighbor pairs of the lattice and constructs the interaction and chemical potential terms. However, this does not take into account the contributions of the last lattice site when using a FiniteChain lattice.

The other models have already been implemented correctly by running through the vertices of the lattice instead. This PR fixes the Bose-Hubbard Hamiltonian which seems to have been left out.

codecov[bot] commented 7 months ago

Codecov Report

Attention: 32 lines in your changes are missing coverage. Please review.

Comparison is base (e880f9e) 51.08% compared to head (c8f4005) 50.00%. Report is 5 commits behind head on master.

Files Patch % Lines
src/operators/localoperators.jl 0.00% 25 Missing :warning:
src/models/hamiltonians.jl 30.00% 7 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #9 +/- ## ========================================== - Coverage 51.08% 50.00% -1.09% ========================================== Files 16 16 Lines 1245 1272 +27 ========================================== Hits 636 636 - Misses 609 636 +27 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.