QubitProducts / exporter_exporter

A reverse proxy designed for Prometheus exporters
Apache License 2.0
336 stars 55 forks source link

[Feature request] Add HTTP basic auth ? #4

Closed rdegez closed 6 years ago

rdegez commented 7 years ago

Hi,

First of all: I was looking for a small & simple, easy to deploy on various system (golang, yeay!), tls-enabled http proxy to secure all prometheus exporter for some time and it your exporter_exporter is doing exactly that! Thanks a lot :-) (and the consistency with other prometheus components is very welcome)

I was wondering if you would consider adding basic http-auth to remove the burden of using tls-client cert verification to secure the access to the metrics?

Cheers

thomasf commented 6 years ago

I am a bit against this since it more or less encourages unsafe deployments without using encryption at all which isnt a secure access by any standard. If you are using something else for SSL termination you could add the auth there?

If anything It should be Bearer authentication and not basic.

rdegez commented 6 years ago

Even better, thanks a lot!