QuentinGruber / h1z1-server

Library used to emulate h1z1 game servers
https://h1emu.com
GNU General Public License v3.0
93 stars 54 forks source link

Properly await for world save #2096

Closed QuentinGruber closed 2 months ago

QuentinGruber commented 2 months ago

TL;DR

Refactor to use async/await in the saveWorld method of ZoneServer2016.

What changed?

The saveWorld method in src/servers/ZoneServer2016/zoneserver.ts was refactored to use async/await instead of promise chaining. This enhances code readability and maintainability.

How to test?

Ensure that the world saving functionality still works as expected. Specifically, verify that the world data (characters, constructions, crops, traps, vehicles, etc.) is correctly saved and that proper notifications are sent to admins.

Why make this change?

This change was made to improve the readability and maintainability of the code by leveraging modern JavaScript features.


QuentinGruber commented 2 months ago

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @QuentinGruber and the rest of your teammates on Graphite Graphite

QuentinGruber commented 2 months ago

Maybe fix https://github.com/QuentinGruber/h1z1-server/issues/1467 who knows

QuentinGruber commented 2 months ago

Merge activity