QuickplayMod / quickplay

Minecraft mod that allows Hypixel users to quickly join games and execute functions on the network.
https://bugg.co/quickplay/
Other
20 stars 5 forks source link

Updates to commands do not transfer over to keybinds #80

Open robere2 opened 6 years ago

robere2 commented 6 years ago

At the moment, if a user keybinds a command, that command is then saved along with its name to a keybind. If that command is ever updated or removed or has its name changed, the keybind still persists. On the other hand, game lobbies (i.e. Arcade, Bedwars, etc). all receive updates when they're changed, due to their unlocalized name.

Games should be saved based off of a unique identifier, and when that identifier is removed or changed, those changes are applied to the keybinds as well.

robere2 commented 5 years ago

Important to note we don't necessarily want to remove keybinds when they are removed from the document. If, for example, something goes wrong and the backend reports a blank game list, we don't want to remove all keybinds.

robere2 commented 4 years ago

Branch https://github.com/robere2/Quickplay2.0/tree/socket-experimentation will fix this.