search

QuinterApp / Quinter

The accessible Quinter Twitter client
11 stars 9 forks source link

Fixed the calculation method of the number of characters when composing a tweet #2 #4

Closed riku22 closed 3 years ago

riku22 commented 3 years ago

Fix issue # 2.

TheQuinbox commented 3 years ago

Hi, Looks pretty good, but I noticed you removed event from TweetGui.maximum, when WX passes it. Is there a reason for this, and will it still run?

TheQuinbox commented 3 years ago

I would also say this is worthy of listing in the changelog for the next version. Can you do this please?

riku22 commented 3 years ago

Looks pretty good, but I noticed you removed event from TweetGui.maximum, when WX passes it. Is there a reason for this, and will it still run?

The text Maximum setting isn't very useful, so I changed it to play the sound during the calculation.

I would also say this is worthy of listing in the changelog for the next version. Can you do this please?

Done.

TheQuinbox commented 3 years ago

It seems TweetGui.chars is never reached. This allows you to type way more text in the field than the limit. Is it maybe possible to make this work with wx.TextCtrl.SetMaxLength?

TheQuinbox commented 3 years ago

OK actually, I'm having some issues. Trying to fix them. Module object is not callable.

TheQuinbox commented 3 years ago

OK, all fixed. :). Thanks for your contribution!