Closed hudson-newey closed 8 months ago
Size Change: +21 B (0%)
Total Size: 2.9 MB
Filename | Size | Change |
---|---|---|
dist/workbench-client/browser/main.********.js |
1.06 MB | +12 B (0%) |
dist/workbench-client/server/main.js |
1.78 MB | +9 B (0%) |
6 files 6 suites 7m 28s :stopwatch: 21 258 tests 20 634 :heavy_check_mark: 624 :zzz: 0 :x: 21 366 runs 20 742 :heavy_check_mark: 624 :zzz: 0 :x:
Results for commit 2fc01abe.
:recycle: This comment has been updated with latest results.
Bug fix: allow setting location on sites/points to null
Currently, it is impossible to remove the location of a site/point.
This PR adds the ability for users to completely remove site locations by setting both the "longitude" and "latitude" inputs to empty values on the site/point edit page.
Changes
location-input.component.ts
so that it also updates the modelscustomLongitude
andcustomLatitude
location-input.component.spec.ts
to test that the correct error messages are shown when only a longitude or only a latitude is inputlocation-input.component.spec.ts
to test that location is emitted as null when both the inputs are emptyProblems
None
Issues
2040
Visual Changes
None
Final Checklist
npm run lint
)npm run test:all
)