QutEcoacoustics / workbench-client

workbench-client: a client side browser application for interacting with acoustic workbenches
Other
8 stars 1 forks source link

Bug fix: allow setting location on sites/points to null #2098

Closed hudson-newey closed 8 months ago

hudson-newey commented 8 months ago

Bug fix: allow setting location on sites/points to null

Currently, it is impossible to remove the location of a site/point.

This PR adds the ability for users to completely remove site locations by setting both the "longitude" and "latitude" inputs to empty values on the site/point edit page.

Changes

Problems

None

Issues

2040

Visual Changes

None

Final Checklist

github-actions[bot] commented 8 months ago

Size Change: +21 B (0%)

Total Size: 2.9 MB

Filename Size Change
dist/workbench-client/browser/main.********.js 1.06 MB +12 B (0%)
dist/workbench-client/server/main.js 1.78 MB +9 B (0%)
ℹ️ View Unchanged | Filename | Size | | :--- | :---: | | `dist/workbench-client/browser/assets/environment.json` | 555 B | | `dist/workbench-client/browser/chunk-7SGCG2G3.js` | 1.08 kB | | `dist/workbench-client/browser/index.html` | 4.1 kB | | `dist/workbench-client/browser/manifest.json` | 150 B | | `dist/workbench-client/browser/polyfills.********.js` | 12.2 kB | | `dist/workbench-client/browser/styles.********.css` | 32.3 kB | | `dist/workbench-client/server/776.js` | 4.2 kB |

compressed-size-action

github-actions[bot] commented 8 months ago

Unit Test Results

         6 files           6 suites   7m 28s :stopwatch: 21 258 tests 20 634 :heavy_check_mark: 624 :zzz: 0 :x: 21 366 runs  20 742 :heavy_check_mark: 624 :zzz: 0 :x:

Results for commit 2fc01abe.

:recycle: This comment has been updated with latest results.