Closed hudson-newey closed 5 months ago
Size Change: +480 B (0%)
Total Size: 3.01 MB
Filename | Size | Change | |
---|---|---|---|
dist/workbench-client/browser/index.html |
4.71 kB | +2 B (0%) | |
dist/workbench-client/browser/main-DIUN7J24.js |
0 B | -1.07 MB (removed) | π |
dist/workbench-client/server/main.js |
1.87 MB | +237 B (0%) | |
dist/workbench-client/browser/main-KT22LVUI.js |
1.08 MB | +1.08 MB (new file) | π |
βββββββββ6 filesβββββββββββ6 suitesβββ8m 57s :stopwatch: 23β370 testsβ22β842 :heavy_check_mark:β528 :zzz:β0 :x: 23β592 runsββ23β064 :heavy_check_mark:β528 :zzz:β0 :x:
Results for commit c44f04ea.
:recycle: This comment has been updated with latest results.
Don't send auth token when calling
/status
At the moment, the website status service contacts the
/status
endpoint with a Bearer token in theAuthentication
request headers.This can cause the request to fail and incorrectly report an "Unhealthy" status when the website is actually healthy.
This PR modifies some very critical code that impacts a vast majority of the website
Changes
AUTHENTICATION_CONTEXT
token toapi.interceptor.service.ts
. This allows us to conditionally append theAuthentication
token in the interceptor (defaults to sending the auth token)withCredentials
tobaw-api.service.ts
httpGet
,httpPost
,httpPut
, andhttpDelete
. This option takes a property{ withCredentials: boolean }
that can be used to conditionally add the auth token to requestsBawServiceOptions
website-status.service.ts
(to prevent regressions in the future where we could change the caching strategy without considering this service)options
inbaw-api.service.ts
http functions toheaders
(because they are always used in the headers, and it can now cause confusion as these methods can take option objects)Problems
None
Issues
Fixes: #2124
Visual Changes
None
Final Checklist
npm run lint
)npm run test:all
)