search

Quuxplusone / LLVMBugzillaTest

0 stars 0 forks source link

Merge c9539f957f57c0c2c59dab98f25215f241d4debf into 13.0.1 #51522

Open Quuxplusone opened 2 years ago

Quuxplusone commented 2 years ago
Bugzilla Link PR52555
Status NEW
Importance P release blocker
Reported by Brad Smith (brad@comstyle.com)
Reported on 2021-11-18 21:34:36 -0800
Last modified on 2021-11-23 14:38:13 -0800
Version unspecified
Hardware Other All
CC dimitry@andric.com, llvm-bugs@lists.llvm.org, neeilans@live.com, nemanja.i.ibm@gmail.com, richard-llvm@metafoo.co.uk, tstellar@redhat.com
Fixed by commit(s) rGc9539f957f57c0c2c59dab98f25215f241d4debf
Attachments
Blocks PR52147
Blocked by
See also 
Please merge https://github.com/llvm/llvm-
project/commit/c9539f957f57c0c2c59dab98f25215f241d4debf.

[PATCH] [PowerPC] Define XL-compatible macros only for AIX and Linux

Since XLC only ever shipped on PowerPC AIX and Linux, it is not reasonable to
provide the compatibility macros on any target other than those two. This patch
restricts those macros to AIX/Linux.
Quuxplusone commented 2 years ago

Yeah having this one in 13.0.1 would be nice. We already use this in FreeBSD. :)

Quuxplusone commented 2 years ago

Hi Unassigned,

What is your opinion on backporting this?

https://reviews.llvm.org/rGc9539f957f57c0c2c59dab98f25215f241d4debf

Quuxplusone commented 2 years ago

FWIW I brought this up originally, I think on IRC maybe even, and Nemanja implemented the fix. Nemanja, can you please give a thumbs up? :)

Quuxplusone commented 2 years ago

Yes, please go ahead and merge this.