QwikDev / qwik

Instant-loading web apps, without effort
https://qwik.dev
MIT License
20.85k stars 1.31k forks source link

fix(insights): minify ping script and externalize zod #6953

Closed wmertens closed 1 month ago

wmertens commented 1 month ago

zod was being built into the library, and the script wasn't minified and was actually broken because fn.toString() didn't include a helper that rollup injected

changeset-bot[bot] commented 1 month ago

⚠️ No Changeset found

Latest commit: 7a163a66ed029079129b9fb1804b422272a60d3b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

pkg-pr-new[bot] commented 1 month ago

Open in Stackblitz

npm i https://pkg.pr.new/@builder.io/qwik@6953
npm i https://pkg.pr.new/@builder.io/qwik-city@6953
npm i https://pkg.pr.new/eslint-plugin-qwik@6953
npm i https://pkg.pr.new/create-qwik@6953

commit: 7a163a6

github-actions[bot] commented 1 month ago
built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ✅ Ready (View Log) Visit Preview 7a163a66ed029079129b9fb1804b422272a60d3b