QwikDev / qwik

Instant-loading web apps, without effort
https://qwik.dev
MIT License
20.85k stars 1.31k forks source link

fix(computed): retry qrl execution on throwing promise #6992

Closed Varixo closed 1 month ago

Varixo commented 1 month ago

When we are executing the computedIfNeeded function we can throw a promise (a qrl) if the qrl is not resolved, then we should retry execution of it.

This is a workaround until a complex fix will be implemented.

changeset-bot[bot] commented 1 month ago

⚠️ No Changeset found

Latest commit: 39118547523946df78e071725922b39bc4029bf4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

pkg-pr-new[bot] commented 1 month ago

Open in Stackblitz

npm i https://pkg.pr.new/@builder.io/qwik@6992
npm i https://pkg.pr.new/@builder.io/qwik-city@6992
npm i https://pkg.pr.new/eslint-plugin-qwik@6992
npm i https://pkg.pr.new/create-qwik@6992

commit: 3911854

github-actions[bot] commented 1 month ago
built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ✅ Ready (View Log) Visit Preview 39118547523946df78e071725922b39bc4029bf4