QwikDev / qwik

Instant-loading web apps, without effort
https://qwik.dev
MIT License
20.88k stars 1.31k forks source link

cleaned the `createQrl` code #7093

Closed shairez closed 3 days ago

shairez commented 5 days ago

What is it?

Description

This PR should make the complicated code of createQrl a little bit easier to follow.

Renamed the invokeFn as it doesn't really mean what you think it means...

and sorted the functions based on their order of their invocation, so it'll reduce the "scroll fatigue" caused by scrolling down and up multiple times just in order to follow the complicated timeline as if it was the movie pulp fiction o something... 😅

Checklist

changeset-bot[bot] commented 5 days ago

⚠️ No Changeset found

Latest commit: 5977b2b84a94f9cd6900daa5d3c83f5c1ac02d6d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

wmertens commented 4 days ago
ReferenceError: Cannot access 'NEEDS_COMPUTATION' before initialization