Fix #191 and #188 - Githubissues

R-ArcGIS / arcgislayers

ArcGIS Location Services

http://r.esri.com/arcgislayers/

Apache License 2.0

39 stars 9 forks source link

Fix #191 and #188 #192

Closed elipousson closed 3 months ago

elipousson commented 3 months ago

Checklist

[X] update NEWS.md
[X] documentation updated with devtools::document()
[-] devtools::check() passes locally

Changes

Fixes #191 by adding a helper function (get_query_resps()) that handles layers that don't support pagination by using a standard query request.

Also fixes the CRS bug #188 using a similar approach as the esri2sf package.

Issues that this closes

Fix #191 and #188

Follow up tasks

None identified.

JosiahParry commented 3 months ago

Thank you @elipousson! I pushed a single change that just adds comments to the function so that I can remember what is happening inside this function later.

Once CI is green ill smash merge

JosiahParry commented 3 months ago

Windows is failing entirely illegibly. That can be a me problem at a later date. Thank you so much!