R-ArcGIS / arcgislayers

Access ArcGIS Data and Location Services

http://r.esri.com/arcgislayers/

Apache License 2.0

47 stars 10 forks source link

Add support for `update_layer` #193

Open elipousson opened 5 months ago

elipousson commented 5 months ago

Checklist

[ ] update NEWS.md
[ ] documentation updated with devtools::document()
[ ] devtools::check() passes locally

Changes

This is a preliminary draft to add support for the updateDefinition end point #127

Issues that this closes

127

Follow up tasks

Follow-up tasks to be added as this PR develops.

JosiahParry commented 5 months ago

Can we change this to update_definition() to match the endpoint? The irony is that I manually crafted my first updateDefinition request yesterday lol! The tough part I think for me, is figuring out how to insert /admin into the URL

JosiahParry commented 5 months ago

@elipousson is this ready for review? I’m going to start prepping for release in the next few days.

elipousson commented 5 months ago

@JosiahParry It still needs some work before review! Not sure I'm going to get this in shape for review in advance of your clean-up for CRAN submission but I'll tag you and mark it as ready for review as soon as I have it working.

JosiahParry commented 5 months ago

No worries! I just wanted to check

JosiahParry commented 4 months ago