Draft: token overhaul - Githubissues

R-ArcGIS / arcgisutils

http://r.esri.com/arcgisutils/

Apache License 2.0

15 stars 2 forks source link

Draft: token overhaul #19

Closed JosiahParry closed 9 months ago

JosiahParry commented 9 months ago

This PR addresses the need for complete token handling overhaul as described in https://github.com/R-ArcGIS/arcgislayers/discussions/132

set_auth_token() is removed in favor of set_arc_token()
set_arc_token() can set a single token or many tokens as key-value pairs
- tokens are stored in a package level environment and fetched from them using arc_token()
the PR also begins to reorganize some files

TODO

arcgisutils

[x] modify auth_ functions to set arcgis_host field in the token after being created
[x] obj_check_token() should also verify that there is a non-null & scalar host set in the arcgis_host
[x] refactor fetch_layer_metadata()
[x] ~~refactor count_features()~~ removed from package since unused in arcgislayers

arcgislayers

[x] remove host arguments from arcgislayers function and extract from httr2_token object
[x] utilize arc_base_req()

Follow up tasks:

rewrite authorization articles
remove any instance of set_auth_token()
utilize arc_base_req() in all functions in {arcgislayers} to ensure that tokens are handled correctly
test reading and writing private sources with new token format

mmachir commented 9 months ago

FYI - info returned by arc.check_portal():

JosiahParry commented 9 months ago

Closes https://github.com/R-ArcGIS/arcgisutils/issues/11