[WIP] Migrate to GitHub-hosted runners

R3BRootGroup / R3BRoot

Framework for Simulations and Data Analysis of R3B Experiment

https://github.com/R3BRootGroup/R3BRoot/wiki

GNU General Public License v3.0

18 stars 104 forks source link

[WIP] Migrate to GitHub-hosted runners #806

Closed kresan closed 1 year ago

kresan commented 1 year ago

Describe your proposal.

Run R3BRoot CI on the GitHub-hosted Ubuntu 18.04
Use FairSoft and FairRoot from CVMFS (versions will be updated soon)
Only cvmfs package needs to be installed and configured - takes 1 min
2 cores are available per runner

Mention any issue this PR is resolved or is related to.

Checklist:

[x] Rebased against dev branch
[x] My name is in the resp. CONTRIBUTORS/AUTHORS file
[x] Followed the seven rules of great commit messages

inkdot7 commented 1 year ago

This sounds like a very good idea to try out!

Questions:

Is it possible to limit the run-time of jobs? (otherwise wild infinite-looping code may use up a lot of CI time) (I am in favour of running very many CI jobs, so this is more a sanity guard, should not be a hindrance)
Is it possible to have CI jobs run automatically before making PRs? (not really related to using ubuntu/cvmfs) but also very useful, c.f. #777)
It seems the current commit runs fewer jobs (just 1) than other typical current PRs (4). WIP?

jose-luis-rs commented 1 year ago

Thanks @kresan, I guess we can still use the CDash system to check the errors, warnings, ..., right?

kresan commented 1 year ago

I do not know yet. We need to look in the workflow settings.
You need to be a member of the R3BRootGroup to be able to run workflows. Should I add you that we can test this feature?
Yes, WIP. I have adjusted title and label.

kresan commented 1 year ago

If one runs ./Dart.sh inside of the workflow, then the results will be published to CDash. That did not change.

For the moment as WIP I use cmake / make, without ctest.

inkdot7 commented 1 year ago

@kresan yes, please add me, then I'll see if I can hit the buttons to run some job.

inkdot7 commented 1 year ago

After a job finished, I saw the following:

CI C17++: .github#L1
The ubuntu-18.04 environment is deprecated, consider switching to ubuntu-20.04(ubuntu-latest), or ubuntu-22.04 instead. For more details see https://github.com/actions/virtual-environments/issues/6002

Is there a particular reason to use the 18.04 environment?

Also, just building R3BRoot took about 14 minutes. That is a long time to wait. I would advocate to use wider machines, at least 4 cores.

kresan commented 1 year ago

Currently, fairsoft.gsi.de supports only Ubuntu 18.04. I will ask Florian to build FairSoft and FairRoot for 22.04. I think there was simply no request before.

inkdot7 commented 1 year ago

What are the current outstanding issues with this PR?

kresan commented 1 year ago

Due to time constrains I can not continue working in this direction. @jose-luis-rs how do we proceed? Should we merge and somebody else develops on top of what is in this PR?

jose-luis-rs commented 1 year ago

Due to time constrains I can not continue working in this direction. @jose-luis-rs how do we proceed? Should we merge and somebody else develops on top of what is in this PR?

Hi, I have it running for other repositories, but we will need ubuntu-22-04 with fairsoft-nov22p1 and fairroot 18.8.X, is this possible? I have a similar problem due to other projects.

YanzhaoW commented 1 year ago

@kresan @jose-luis-rs I could do this since I have already made github-hosted server for clang-tidy (with successful compilation).

But I will build upon my clang-tidy workflow, which is actually partly based on this PR.

jose-luis-rs commented 1 year ago

@kresan @jose-luis-rs I could do this since I have already made github-hosted server for clang-tidy (with successful compilation).

But I will build upon my clang-tidy workflow, which is actually partly based on this PR.

If you have time I don't see any problem. Thanks in advance

kresan commented 1 year ago

@jose-luis-rs @YanzhaoW There are new installations for Ubuntu 22.04 available now:

/cvmfs/fairsoft.gsi.de/ubuntu2204

@YanzhaoW Thanks for picking up on this.

jose-luis-rs commented 1 year ago

@jose-luis-rs @YanzhaoW There are new installations for Ubuntu 22.04 available now:

/cvmfs/fairsoft.gsi.de/ubuntu2204

@YanzhaoW Thanks for picking up on this.

Thank you @kresan!

YanzhaoW commented 1 year ago

@kresan But we should keep using debian 10, right? It's the same system as we use in the lxir server.

jose-luis-rs commented 1 year ago

@kresan But we should keep using debian 10, right? It's the same system as we use in the lxir server.

I will have both, Ubuntu 22.04 and debian10, running for sofia and asyeos

YanzhaoW commented 1 year ago

@kresan But we should keep using debian 10, right? It's the same system as we use in the lxir server.

I will have both, Ubuntu 22.04 and debian10, running for sofia and asyeos

Ok, sure.

jose-luis-rs commented 1 year ago

Solved with #840