R3BRootGroup / R3BRoot

Framework for Simulations and Data Analysis of R3B Experiment
https://github.com/R3BRootGroup/R3BRoot/wiki
GNU General Public License v3.0
18 stars 104 forks source link

Add input parameter for Tamex channel and manual update #869

Closed YanzhaoW closed 1 year ago

YanzhaoW commented 1 year ago
  1. The parameter of the Tamex channel can be setup through the user interface.
  2. Update the manual.

Checklist:

YanzhaoW commented 1 year ago

Hi, @jose-luis-rs. It's now ready to be merged if no other problem.

YanzhaoW commented 1 year ago

Hi @jose-luis-rs . This PR is ready. Could you merge it?

jose-luis-rs commented 1 year ago

Hi @YanzhaoW

Sorry, I hadn't seen this PR, just a simple question about the R3BNeulandDigitizer class. In the function R3BNeulandDigitizer::SetParContainers() the use of FairRunAna is mandatory, so this means that we cannot run the simulations + Digitizer tasks simultaneously. Can we make it optional?

In some cases, we want to produce "Point" and "Hit" data simultaneously without the use of extra macros.

YanzhaoW commented 1 year ago

Hi @jose-luis-rs

I think this was added long time ago. The main reason of this is because the simulation of NeuLAND by FairRunSim is very very slow compared to FairRunAna. So it's strongly encourage to run the simulation only one time, and then change or check something using FairRuaAna. I would just keep making FairRunAna mandatory.