search

RBVI / ChimeraX

Source code for molecular graphics program UCSF ChimeraX
https://www.rbvi.ucsf.edu/chimerax/
Other
136 stars 24 forks source link

prereqs/pips: Remove duplicate entries for Cython, grako #7

Closed zjp closed 2 years ago

zjp commented 2 years ago

We install Cython and grako in app_requirements.txt and they are indeed in my environment and in users' bug reports.

tomgoddard commented 2 years ago

I don't understand the purpose of this pull request. The build_requirements.txt file includes the PyPi packages needed to build ChimeraX, ie needed at build time, and both Cython and Grako are needed at build time. I guess grako is also needed in the app and so should appear in app_requirements.txt. But I don't think Cython is needed in the distribution, it is only needed as a build tool and build time so should not be in app_requirements.txt. I guess maybe our build system is using the app version of Cython but that just seems wrong since it should not be distributed with the app.

zjp commented 2 years ago

You're so right, this is a careless one.