RDFLib / prez-ui

BSD 3-Clause "New" or "Revised" License
10 stars 7 forks source link

Labels refactor, resource routes & testing frameworks #116

Closed jamiefeiss closed 1 year ago

jamiefeiss commented 1 year ago

Replaced profile-driven label predicates with the list of annotation predicates retrieved from the root API endpoint, as in https://github.com/RDFLib/prez/pull/164. Labels, descriptions & provenance are now retrieved using getAnnotation() and the convenience functions getLabel(), getDescription() & getProvenance().

Also refactored the types & props for PropTable.vue and its children components following the annotation predicates refactor.

Updated the routes for dcat:Resources in CatPrez to use the following routes:

Added some initial unit, component & end-to-end tests as well as benchmarking using the Vitest & Cypress testing frameworks.

Resolves #115.

recalcitrantsupplant commented 1 year ago

Haven't had a look at the test parts yet - visually checked the functionality and it looks fine. If a link is not available for a resource it means there is no class information for it. At present the UI provides a link to the current page - which is probably not expected. We should have a think about what to do in this scenario - might be best to consider it incomplete data for the resource and not return it in the listing in the first place.

edmondchuc commented 1 year ago

Tested it locally with the ANU instance of catprez and it looks good!