search

REhints / HexRaysCodeXplorer

Hex-Rays Decompiler plugin for better code navigation
2.41k stars 388 forks source link

Support option for type creation fields to be in hex #30

Closed grant-h closed 8 years ago

grant-h commented 8 years ago

Just a small nit when reconstructing types. It's hard to compare memory traces to undefined field_%d variables as measurements are usually done in hex. I may submit a PR for this...

Personally I think there shouldn't be an option and that the default should be hex.

https://github.com/REhints/HexRaysCodeXplorer/blob/master/src/HexRaysCodeXplorer/TypeReconstructor.cpp#L547-L548

Atvaark commented 8 years ago

Agreed.

Adding new fields to a reconstructed type in the structs window also uses the field offset in hex.

matrosov commented 8 years ago

Good idea. We will include this fix in the next release.