search

RGLab / openCyto

A package that provides data analysis pipeline for flow cytometry.
GNU Affero General Public License v3.0
77 stars 29 forks source link

ODC-188 drop legacy GatingSetList from openCyto test suite. #266

Open djhammill opened 3 weeks ago

djhammill commented 3 weeks ago

@amcdavid this is a very minor change to remove the legacy GatingSetList constructor from the openCyto test suite.

djhammill commented 3 weeks ago

There are a few more warnings in the test suite but they are all coming from flowCore:::.flowParamMatch() - I am looking into that now.

djhammill commented 3 weeks ago

There was one lingering call to getChannelMarker() where multiple channels are passed by openCyto but only a single channel is expected by getCHannelMarker(). I have added a fix for that too - with this PR I no longer see any warnings in test suite except for the occasional flowClust convergence warning in test-misc.R.