RI-SE / ATOS

ROS2 based platform for coordinating tests of automated vehicles and their surrounding systems.
Mozilla Public License 2.0
14 stars 5 forks source link

ObjectControl: Trigger not found if Action not prefixed with start_ in xosc file #647

Open ceciliahernqvist opened 4 months ago

ceciliahernqvist commented 4 months ago

Describe the bug Delayed start for an object does not work unless actionName for an object is prefixed with "start_", e.g. <Action name="2,start_follow_trajectory">

To Reproduce Steps to reproduce the behavior:

  1. Open a scenariofile with a scenario where an actors movement should be triggered by another actor in the scenario.
  2. Go to ManouverGroup for the triggered actor ID, at the row for <Action name="ActorObjectID,Action"> make sure "Action" does not contain the prefix "start_"
  3. Run scenario with ATOS.
  4. Note that the output will state that no trigger where found for the specified actor, e.g.: [object_control-3] [INFO] [1719314506.627170743] [atos.object_control]: Got trigger start for object 2: 0

Expected behavior Would like ATOS to be able to handle triggers without a specific prefix, or otherwise output a warning message or something about not handling triggers without "start_" prefix.

Screenshots Screenshot from 2024-06-25 13-16-30

Additional context Same issue occurs if there happens to be a space in between ActorObjectID, and Action, e.g. <Action name="2, start_follow_trajectory"> instead of <Action name="2,start_follow_trajectory">