ROBOTIS-GIT / OpenCR

Software for ROS Embedded board (a.k.a. OpenCR). OpenCR means Open-source Control Module for ROS.
Apache License 2.0
382 stars 239 forks source link

Confusion LINEAR/ANGULAR and LEFT/RIGHT #271

Closed savend closed 3 years ago

savend commented 3 years ago

There can be confusion because in the turtlebot3_core the goal_velocity[2] array is given with [LINEAR=0] and [ANGULAR=1] and in the turtlebot3_motor_driver it was received with [LEFT=0] and [RIGHT=1]. Alternative is to define LINEAR 0 and ANGULAR 1 in the turtlebot3_motor_driver.h.

A little detail who can help understanding the code.

ROBOTIS-Will commented 3 years ago

hi @savend Thank you for your contribution. This change has been applied and waiting to be merged into master soon. https://github.com/ROBOTIS-GIT/OpenCR/commit/6be8610536e19a182e3be8932cb88f7199f8ab98 Thanks!