search

ROCm / ROCK-Kernel-Driver

AMDGPU Driver with KFD used by the ROCm project. Also contains the current Linux Kernel that matches this base driver
Other
333 stars 101 forks source link

missing tagged release for rocm-dkms 5.4.5 #148

Closed BenWibking closed 1 year ago

BenWibking commented 1 year ago

Hi,

There is a binary package for ROCm 5.4.5 that includes rocm-dkms 5.4.5, but there's no such tagged release here. Can you provide a tag for this version?

For this release, rocm-smi --showdriverversion shows driver version 5.18.13, which doesn't match PACKAGE_VERSION in drivers/gpu/drm/amd/dkms/config/config.h for any of the tagged releases.

kentrussell commented 1 year ago

The versioning for the amdgpu-dkms package is defined in dkms/configure.ac . From what I can tell, config.h represents the codebase used for the dkms code. This would be 5.18.0 for the 5.4 release. The value defined in configure.ac in the AC_INIT call is the true package version. This represents the code base (5.18) and the number of promotions done to mainline (13 in this case). 5.18.13 is considered to be the true version for that amdgpu-dkms package, as this is always incremented at each promotion.

For my personal reference (I don't handle dkms versioning), where would you be seeing the PACKAGE_VERSION variable used? I can reach out to the dkms packaging guys if this is causing a discrepancy or a mismatch with userspace tools or package managers. Thanks!

BenWibking commented 1 year ago

Ah, ok. Thanks for clarifying. I don't see PACKAGE_VERSION used elsewhere, I had just missed the version number in configure.ac itself.