search

ROCm / rocm-cmake

CMake modules used within the ROCm libraries
https://rocm.docs.amd.com/projects/ROCmCMakeBuildTools/en/latest/
MIT License
62 stars 43 forks source link

fix default installation path on Windows #161

Closed apwojcik closed 1 year ago

apwojcik commented 1 year ago

It is unusual on Windows to manually install in the C:\Program Files directory. It requires Administrator privilege, which is not standard or not easily granted. Only applications managed by the Windows installer are allowed to install in that directory, and cmake install is not one of them. Installing tests in a custom directory provided as a parameter to CMake is also impossible when HEADER_INSTALL_PREFIX is set to C:/Program Files. Moreover, the directory C:\Program Files is for 64-bit applications only. In the case of 32-bit, the installer should use the C:\Program Files (x86) directory instead.

apwojcik commented 1 year ago

The changes from the latest develop branch work for us.