ROCm / rocm-cmake

CMake modules used within the ROCm libraries
https://rocm.docs.amd.com/projects/ROCmCMakeBuildTools/en/latest/
MIT License
62 stars 43 forks source link

Update upper end of cmake_minimum_required range #241

Open lawruble13 opened 1 week ago

lawruble13 commented 1 week ago

CMake 3.31 is dropping support for cmake_minimum_required for versions less than 3.10, but adding 3.25 (which is tested on math-ci) indicates that we test compatibility with 3.25, which causes those warnings to be suppressed.

lawruble13 commented 1 week ago

@pfultz2 I updated CMP0079 to NEW, as it throws a deprecation error when adding the upper end of the range. Is there a reason that needed to have the old behaviour?

pfultz2 commented 22 hours ago

Is there a reason that needed to have the old behaviour?

Either behavior works for ROCMTest module, however, I dont know if some downstream component is relying on the old behavior. If it doesnt break anyone, then using NEW behaviour is a better choice.