RPCS3 / rpcs3

PS3 emulator/debugger
https://rpcs3.net/
GNU General Public License v2.0
15.27k stars 1.9k forks source link

[Regression] Multi-context support pull request breaks inFamous [BCUS98119] #15445

Closed 5kft closed 5 months ago

5kft commented 5 months ago

Quick summary

This change (https://github.com/RPCS3/rpcs3/pull/15421) has broken the rendering of explosions in InFamous (the screen flashes and shows dark flashing geometric patterns), and also has impacted the rendering of the HUD/minimap and target reticle as well.

Other rendering in the game seems fine, it's just shots/explosions and the HUD/reticle that are broken now.

Details

I upgraded to the latest build that includes this pull request: https://github.com/RPCS3/rpcs3/pull/15421, and rendering of explosions in InFamous is completely broken. Reverted to the previous build of RPCS3 that does not include this pull request, and rendering behavior is correct again.

Example screen cap during explosion (just a frame grab, during the explosion it just shows random/flashing full-screen geometric patterns): infamous-broken-explosions (pull 15421)

HUD and minimap (and targeting reticle) are no longer fully rendered: infamous-hud-problems (pull 15421)

Build with regression

v0.0.31-16323-d6f6752a

Attach two log files

RPCS3-build-v0.0.31-16319-0231902a-good.log.gz RPCS3-build-v0.0.31-16323-d6f6752a-(pull-15421)-bad.log.gz

Attach capture files for visual issues

(I tried making an RSX capture but it is difficult pausing and catching the explosions - I included a screen capture above instead)

System configuration

No response

Other details

No response

JimScript commented 5 months ago

For some reason, the UI is fully functional when you're standing on top of Zeke's TV.

kd-11 commented 5 months ago

Hmm, I'm pretty sure this is a pushbuf issue, but need to verify.

kd-11 commented 5 months ago

I was wrong, I broke vertex textures.

kd-11 commented 5 months ago

Fixed by https://github.com/RPCS3/rpcs3/pull/15453

JimScript commented 5 months ago

I downloaded the update and I'm still getting the same vertex explosions and HUD flickering as I was before.

Jack54guythecoder commented 5 months ago

I am trying to make an RSX Capture of Infamous, because if you press L3 a couple of times, it somewhat fixes the HUD. Could I upload an RSX capture for kd-11 to debug?

5kft commented 5 months ago

Indeed, I'm sad to say that build v0.0.31-16338 does not fix the problem - same issue occurs as originally reported...

Raptr12 commented 5 months ago

This same issue is happening with InFamous 2:

Jack54guythecoder commented 5 months ago

image In this moment, it somehow fixes and glitches out

kd-11 commented 5 months ago

Looks like the fix only solved the problem for code veronica which is weird. i guess the changes caused multiple unrelated regressions. I'm not sure how to proceed since this game is notoriously annoying to debug and everyone has different luck reproducing the issue, so I'll do a code analysis to determine the cause.

Raptr12 commented 5 months ago

I was trying previous rpcs3 builds and the build 16299 runs Infamous 1 and 2 without any of this glitches.

5kft commented 5 months ago

Thanks so much @kd-11 - hugely appreciated!

Raptr12 commented 5 months ago

image Thanks @kd-11