search

RTimothyEdwards / magic

Magic VLSI Layout Tool
Other
498 stars 103 forks source link

GCC14 -Wall cleanup series #334

Closed dlmiles closed 1 month ago

dlmiles commented 1 month ago

This cleans up all warnings that have fixes that should not change application behaviour.

dlmiles commented 1 month ago

Correction to DBio.c in one of the commits.

DBio.c edited as my original change was caught out by the incorrect indention of the 'else' keyword and my modification would have caused a NULL deref. Exactly the kind of issue this warning is trying to prevent.

RTimothyEdwards commented 1 month ago

Pulled and merged.

dlmiles commented 1 month ago

Agree modification is same as original (a == b)

a   b    old new
-1, -1 =  1  1 SAME
-1,  0 =  0  0 SAME
-1,  1 =  0  0 SAME
-1,  2 =  0  0 SAME
 0, -1 =  0  0 SAME
 0,  0 =  1  1 SAME
 0,  1 =  0  0 SAME
 0,  2 =  0  0 SAME
 1, -1 =  0  0 SAME
 1,  0 =  0  0 SAME
 1,  1 =  1  1 SAME
 1,  2 =  0  0 SAME
 2, -1 =  0  0 SAME
 2,  0 =  0  0 SAME
 2,  1 =  0  0 SAME
 2,  2 =  1  1 SAME