Rate Limiting Issues With I2P Accesss

RTradeLtd / Temporal

☄️ Temporal is an easy-to-use, enterprise-grade interface into distributed and decentralized storage

https://temporal.cloud

MIT License

226 stars 40 forks source link

Rate Limiting Issues With I2P Accesss #485

Open bonedaddy opened 4 years ago

bonedaddy commented 4 years ago

Describe the bug When users access our service via I2P, all access to the API will appear to be coming from the LAN IP address of our I2P router, as opposed to an actual client IP.

Expected behavior

Dont rate limit I2P users since I2P essentially acts as a "rate limit" anyways.

I'm not quite sure how to solve this without increasing per-IP rate limits.

xiegeo commented 4 years ago

White list LAN IP addresses?

bonedaddy commented 4 years ago

Good idea, i think that's possible with the rate limiter we use? I will check