RWTH-EBC / BESMod

A Modelica library providing building energy system modules
Other
17 stars 0 forks source link

Issue 95 example aix lib hom has no heat losses #96

Closed TobiasSpratte closed 2 weeks ago

TobiasSpratte commented 2 weeks ago

This PR closes issue #95. The missing heat port and the required prescribed heat flow were added.

ebc-aixlib-bot commented 2 weeks ago

Reference results have been displayed graphically and are created under the following page https://rwth-ebc.github.io/BESMod/issue-95-Example_AixLibHOM_has_no_heat_losses/charts

ebc-aixlib-bot commented 2 weeks ago

Thank you for making a Pull Request to BESMod!

Our CI pipeline will help you finalize your contribution. Here's what is typically checked:

If HTML errors occur, I will fix the issues using a separate pull request. For the other checks, I will post the results here: https://rwth-ebc.github.io/BESMod/issue-95-Example_AixLibHOM_has_no_heat_losses/index.html

Tips to fix possible naming violations:

If all CI stages pass and you have addressed possible naming violations, please consider the following:

Once you have addressed these points, you can assign a reviewer. Although this process may seem tedious, ensuring CI passes allows the reviewer to focus their time on the actual modeling rather than syntax and unintended breakages caused by your changes.

If you have any questions or issues, please tag a library developer. Once again, thank you for your valuable contribution!

ebc-aixlib-bot commented 2 weeks ago

Reference results have been displayed graphically and are created under the following page https://rwth-ebc.github.io/BESMod/issue-95-Example_AixLibHOM_has_no_heat_losses/charts