HedgeLib - Custom replacement for std::filesystem::path - Githubissues

Radfordhound / HedgeLib

A C++ library and collection of tools that aims to make modding games in the Sonic the Hedgehog franchise easier.

MIT License

88 stars 24 forks source link

HedgeLib - Custom replacement for std::filesystem::path #66

Closed Radfordhound closed 4 years ago

Radfordhound commented 5 years ago

std::filesystem::path is a great feature of C++17, but it's not perfect. Unfortunately, it brings many problems. For example:

std::filesystem::path makes a ton of unnecessary copies that unfortunately don't get optimized away by any C++ compilers I've tested so far.
XCode 10 and below has very poor support for the \<filesystem> header, meaning HedgeLib doesn't compile on macOS just because we use \<filesystem> occasionally. XCode 11 finally fixes this, however, as of now it still requires you to be on a beta version of macOS which is non-ideal.

I want to make a custom replacement type for std::filesystem::path based off of what I've already done with the Path and INPath headers.

Radfordhound commented 4 years ago

2ed16dc45925e9dedf7e4c888d7ab54ac4956178 Ditches usage of entirely in favor of custom platform-specific functions that are simpler much better optimized. It also means HedgeLib now compiles on macOS.