Closed bhazelton closed 1 year ago
Base: 99.87% // Head: 99.86% // Decreases project coverage by -0.02%
:warning:
Coverage data is based on head (
50d0609
) compared to base (1a39d60
). Patch coverage: 100.00% of modified lines in pull request are covered.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
The pyuvsim errors were not totally expected but not shocking. The problem was that the pyuvsim tests were failing because of not keeping up with pyuvdata, so we didn't pay enough attention to the fact that they were also failing because of the pyradiosky changes in the PR that was just merged (changing over to skycoord). Yesterday we also merged a PR on pyuvsim to fix the other errors and I thought these would just pass but there are some things broken with the newest pyradiosky release.
Most of the problems are minor things in tests, like DeprecationWarnings. There is one breaking change that I think we didn't intend in pyradiosky. It's an API change to read_votable_catalog
that we handled with deprecation warnings in the generic read
but we just changed it and without deprecation in read_votable_catalog
. I will add the proper deprecation for that now in this PR, but pyuvsim should also convert to using the generic read rather than it's built-in function that tries to call the correct specific read function in pyradiosky. We didn't realize it was API breaking because we just changed the names of positional input parameters, but in python positional input parameters can also be called by name and that broke things.
On further inspection, the pyuvsim errors are not easy to fix without a bunch of cludgy code in this PR. I think it's better to merge this and fix pyuvsim asap.
Description
Prepare to release version 0.2.0:
This also includes a one-line fix for a bug when using the branch this in pyuvdata PR: https://github.com/RadioAstronomySoftwareGroup/pyuvdata/pull/1252
The problem is that PR added more handling for a silent keyword in the parameter eq method so we needed to add it in the
TelescopeLocationParameter
that derives from UVParameter.Motivation and Context
closes #85
Checklists:
Bug Fix Checklist:
Version Change Checklist