search

RafaGago / mini-async-log

Non bloated asynchronous logger
Other
220 stars 20 forks source link

Compile time format string checker failing in g++ amd64 compilers. #6

Closed RafaGago closed 8 years ago

RafaGago commented 9 years ago

I don't remember exactly which compiler version is, it's the one bundled in Ubuntu 14.10 amd64.

holenaj commented 8 years ago

Hi Rafa,

I found a similar error using gcc 4.8.5 (the version bundled with CentOS 7). Not sure if it's the same cause as you're seeing in Ubuntu 14.10 amd64, but for me the fix was to change some 1s that were being left-shifted to 1UL, as per the attached diff.

Hope this is helpful, and thanks for the great library!

John gdiff.txt

RafaGago commented 8 years ago

Good catch!

I pushed the fix to the master branch.

Thanks for reporting.