search

RafaelKa / node-serialport-enocean-parser

ESP3 parser for nodes serialport
Do What The F*ck You Want To Public License
6 stars 2 forks source link

decouple Packet detection from ESP3 parsing #26

Closed Holger-Will closed 6 years ago

Holger-Will commented 6 years ago

a follow up for the disussion in #20

Holger-Will commented 6 years ago

one idea is to keep the parser as simple as possible, and have a second parser inherit from first parser and that understands ESP3 types. see #25

Holger-Will commented 6 years ago

@RafaelKa I really like some clarification on this, so i can go forward implementing the classes.

Holger-Will commented 6 years ago

i could go ahead implementing the basic classes but without parsing the actual content... But that would be inconsistent, because in the case of Radio_ERP1 i already parse the content (to get the senderId for example)

Holger-Will commented 6 years ago

fixed with #25