search

RafaelKa / node-serialport-enocean-parser

ESP3 parser for nodes serialport
Do What The F*ck You Want To Public License
6 stars 2 forks source link

evaluate test and code for checking CRC8 for Datas #28

Closed RafaelKa closed 6 years ago

RafaelKa commented 6 years ago

https://github.com/RafaelKa/node-serialport-enocean-parser/blob/25145346ff5c38e7e1e26397366565fde403cbbf/ESP3Parser.js#L99-L102

is not covered by

https://github.com/RafaelKa/node-serialport-enocean-parser/blob/25145346ff5c38e7e1e26397366565fde403cbbf/test/ESP3Parser.test.js#L71-L83

See: https://coveralls.io/builds/20408130/source?filename=ESP3Parser.js#L101

Originally posted by @RafaelKa in https://github.com/RafaelKa/node-serialport-enocean-parser/pull/27/comment#issuecomment-443538040

Holger-Will commented 6 years ago

you forgot to actually write the data to the stream in that test... ;-) esp3parser.write(byteStream) after line 81

Holger-Will commented 6 years ago

tracking bug #12