Add fallbacks for icons not in Freedesktop icon set?

peteruithoven commented 2 months ago

Clapper relies on icons missing in some icon themes (like the one from elementary), for example:

audio-volume-overamplified-symbolic
power-profile-power-saver-symbolic
power-profile-balanced-symbolic
power-profile-performance-symbolic

While opening issues (1, 2) for adding those icons I got a seemingly valid response:

If it is not listed in the Freedesktop icon set, they should embed the icon in the application directly for fallback

See https://developer.gnome.org/documentation/tutorials/themed-icons.html#resources for how to do it

See issue: https://github.com/elementary/icons/issues/1265

Relevant icons in the Adwaita set:

Rafostar commented 2 months ago

Then its gonna be what I mentioned to you in the git discussion:

I have seen ideas for apps to ship the icons which they use to show as fallback, but (currently???) I decided to not do that. It would not fix your "star" problem and other icons would look out of place anyway.

As long as people are fine with that, sure I can ship them with the app.

tintou commented 2 months ago

It allows this to not be your problem anymore :slightly_smiling_face: and you're sure that an image (even if a bit out of place) will at least being shown for any user on any disto

peteruithoven commented 2 months ago

Just to clarify, if we add fallbacks, I assume I'll still see the star for the info icon, because there is an icon for that in the elementary icon theme, which I think is fine.

I agree with Tintou here, that having an icon, even out of place is better than none.

I also understand that this requires extra work and maintenance if the Adwaita icons for example change.

Rafostar / clapper

Add fallbacks for icons not in Freedesktop icon set? #432