search

Rage-Modding-Collective / RDR1-Example-Script

An example script for the RDR1 Pc remake based on ScriptHookRDR1
MIT License
6 stars 0 forks source link

Extra native hashes #1

Open emoose opened 3 weeks ago

emoose commented 3 weeks ago

Not really sure where to submit these...

https://github.com/Rage-Modding-Collective/RDR1-Example-Script/blob/01c91aa33481d42a71556f4af1d4fd369ce618d2/inc/natives.h#L1611-L1612 0x4DB7C61C = GRINGO_ATTACH_PROP_TO_ANIM

https://github.com/Rage-Modding-Collective/RDR1-Example-Script/blob/01c91aa33481d42a71556f4af1d4fd369ce618d2/inc/natives.h#L51-L52 0x0733E811 = IS_AREA_OBSTRUCTED2

https://github.com/Rage-Modding-Collective/RDR1-Example-Script/blob/01c91aa33481d42a71556f4af1d4fd369ce618d2/inc/natives.h#L1686-L1687 0x5E339E16 = FLOAT_TO_STRING_VERBOSE

https://github.com/Rage-Modding-Collective/RDR1-Example-Script/blob/01c91aa33481d42a71556f4af1d4fd369ce618d2/inc/natives.h#L3412-L3418 0x0E453CF0 = MAKE_TIME_OF_DAY_EX 0x2DB3AC0F = IS_LATER_THAN 0x9C9529D8 = IS_EARLIER_THAN 0x243AF970 = TIME_IS_IN_RANGE 0xD4FECCBC = ADVANCE_TIME_HOURS

Used hash tool in MagicRDR to check them, maybe worth keeping an issue open in case others are found?

fingaweg commented 2 weeks ago

Hey @emoose,

consider opening a pull request here: https://github.com/TheRouletteBoi/rdr-nativedb-data/pulls

not sure if @TheRouletteBoi currently maintains this or wants to separate it for PC builds.

Best Regards

emoose commented 2 weeks ago

Ahh thanks, didn't see that repo before, made a PR at https://github.com/TheRouletteBoi/rdr-nativedb-data/pull/1

(btw I noticed some of the hashes I posted here are actually included in magicrdr already, but are missing from this repo & the nativedb, maybe could be worth going through and seeing if there's any other missing ones in there...)

emoose commented 2 weeks ago

https://github.com/TheRouletteBoi/rdr-nativedb-data was updated with ~908 extra names, I think the natives.h here was based on that, so may want to pull newer natives.h from https://therouletteboi.github.io/rdr/nativedb/

kepmehz commented 2 weeks ago

https://github.com/TheRouletteBoi/rdr-nativedb-data was updated with ~908 extra names, I think the natives.h here was based on that, so may want to pull newer natives.h from https://therouletteboi.github.io/rdr/nativedb/

Thanks for the update. I will merge them tomorrow.

emoose commented 2 weeks ago

Nice, there might be another update soon to add some PC/nsw natives too, made PR for it at https://github.com/TheRouletteBoi/rdr-nativedb-data/pull/3

kepmehz commented 2 weeks ago

Perfect, I will wait for him approving this PR then

kepmehz commented 2 weeks ago

Actually, I will probably just setup an automation that updates the natives.json file periodically and creates a natives.h file