search

Railroad-Team / Modding-IDE

An IDE built specifically for Modding Minecraft Java Edition, containing many useful features that will be helpful for modders.
GNU General Public License v3.0
11 stars 15 forks source link

Issue with Discord RPC #47

Open Cy4Shot opened 3 years ago

Cy4Shot commented 3 years ago

When having more than one instance of RailRoad open, The Discord RPC crashes for obv reasons..

Add some kinda protection maybe?

image

jojo2357 commented 3 years ago

Upon replicating the issue, I found that it is handled by the library and the stack trace is printed no matter what. In fact, when you run two instances and close the first one, the rich presence still persists. I suppose a check could be added though since it seems to be in the same place every time.

jojo2357 commented 3 years ago

Can someone on a mac/linux give the location of their dll's? that way i can add a checker to see if it is in use because y not

tesinormed commented 3 years ago

what dlls

jojo2357 commented 3 years ago

see the image and replicate the issue and provide the location of the file in use (if it even works at all)

tesinormed commented 3 years ago

runs just fine

tesinormed commented 3 years ago

or not. the first instance just crashed but not for the same reason

tesinormed commented 3 years ago

https://user-images.githubusercontent.com/59344510/107742242-87574c80-6cc3-11eb-98d3-c7fcd0df7489.mp4

jojo2357 commented 3 years ago

Thanks i think its handled by the lib so i won't look into a fix

Cy4Shot commented 3 years ago

Thanks i think its handled by the lib so i won't look into a fix

if we cant be bothered to check it ourselves we can try to catch that error. bad code but i don't see alternatives .

jojo2357 commented 3 years ago

It cant be caught since the library catches it and prints the stack trace