search

RailsEventStore / ecommerce

Application with CQRS and Event Sourcing built on Rails and Rails Event Store
MIT License
425 stars 72 forks source link

Handle error on adding product to submitted order from another tab #352

Closed bingerxd closed 1 year ago

netlify[bot] commented 1 year ago

Deploy Preview for ecommerce-events ready!

Name Link
Latest commit fb5a5b32980ec7e29563e6eacf62ec148ff245dd
Latest deploy log https://app.netlify.com/sites/ecommerce-events/deploys/64e7f8d82fa12d0008a2f61d
Deploy Preview https://deploy-preview-352--ecommerce-events.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

andrzejkrzywda commented 1 year ago

The fix looks ok to prevent the actual problem.

Ideally, it should be solved somehow on the domain level, but I don't know exactly how. In the spirit of first focusing on stabilizing the app from bugs (and this fixes it), let's go for this.

However, we need an integration test to show the bug that is fixed (and prevents from regresssions in the future). Once we will be able to find a proper domain solution to this, we will change the test to unit test.