search

Raku / rakubrew.org

rakubrew.org website
https://rakubrew.org/
Artistic License 2.0
8 stars 5 forks source link

Use bash as shell for installation. #11

Closed fluca1978 closed 4 years ago

fluca1978 commented 4 years ago

The sh available on Linux does not include a pipefail option to set, that appear to be present on Bash and Zsh. This has been tested on Ubuntu Linux, I suspect it is the same on other operating systems.

vrurg commented 4 years ago

FreeBSD doesn't have bash installed by default. If memory serves me right, neither OpenBSD does.

AlexDaniel commented 4 years ago

@vrurg the PR itself is right. When using bash-specific features you have to use bash as the shell. Otherwise it will be failing for those who have bash on their systems but have a different default shell.

I guess you're trying to say that the use of pipefail must be eliminated. Yeah, maybe that's a better idea.

vrurg commented 4 years ago

I just noticed that bash is not that omnipresent, as linux users often expect it to be. If pipefail can be eliminated – I think it'd be for better. If not, then the need to have bash installed must be mentioned somewhere.

Hopefully, I made myself clear. More than a week of fighting with bareos makes be rather dull...

patrickbkr commented 4 years ago

This is sadly a duplicate of #8 and has already been fixed back in May. But we still didn't manage to roll out the change to the website. Sorry for that!