search

Ralim / IronOS

Open Source Soldering Iron firmware
https://ralim.github.io/IronOS/
GNU General Public License v3.0
7.29k stars 723 forks source link

boot logos converted to dfu #1228

Closed River-Mochi closed 2 years ago

River-Mochi commented 2 years ago

I got all the Boot logo Art I could find on this github that people shared publicly to be used in pinecil and I converted them to DFU. I made a fork with them in the boot logo folder.

How do I upload it or join it into a pull request for review. It would be nice to include all the Art in one central location like the Boot Logo Folder so people can browse and select what they like to personalize their Pinecil.

Johnex commented 2 years ago

So you want to fork this repository using the links at the top of the page. You will have a copy in your profile, go there, and click "Add files" in the correct folder. It will let you upload all the files and write what changes you made as a comment. Then from the main page of your copy, you will see a button called "Contribute", and click "Open pull request".

River-Mochi commented 2 years ago

don't see a button called Contribute , but I do see 'Pull Request' at the top, which then shows a large green button on the right "New Pull Request"

When I select 'New Pull Request', I see the changes I want to send in, however there is one at the bottom, which is old and I do not want included. I don't see a way to delete it?

discip commented 2 years ago

@River-b You can close this PR, since there is a new approach by the developer on where logos are located and how they are handled. Due to the fact that it is a WIP, there is no official information on that yet.

Johnex commented 2 years ago

@River-b You can either delete the file from your repository file list and create a new pull request (delete the old one) or you can delete the repository and try again.

But maybe wait for @Ralim to reply and see where the file should be placed.