search

RalphTro / epcis-event-hash-generator

ALGORITHM and SOFTWARE PROTOTYPE to uniquely identify/validate the integrity of any EPCIS event through a common, syntax-agnostic approach based on hashing. Takes an EPCIS Document (formatted in either XML or JSON-LD) and returns the corresponding hash value(s).
MIT License
8 stars 4 forks source link

support to generate hash from EpcisQueryDocument #108

Closed dakbhavesh closed 1 year ago

dakbhavesh commented 1 year ago

Dear @RalphTro, It was straightforward to add support for EpcisQueryDocument. I've added XML & JSON-LD test case. Please review and merge if you find it okay.

CC: @Echsecutor

RalphTro commented 1 year ago

Dear @dakbhavesh , Many thanks!

First, I just tried the query documents you inserted (.json + .xml) and they work fine!

Second, I also tried another query document (also in both formats). In this case though, I was returned the following message: 

2023-06-02 08:34:06,430 event_list_from_epcis_document_str (184) [ERROR]:    No EventList found
2023-06-02 08:34:06,430 event_list_from_epcis_document_str (185) [ERROR]:    Input string does not contain a valid EPCIS XML document with EventList.

Third, I also tried a query document which is embedded in a SOAP envelope (I do not know whether we want to support such scenarios? From my POV, it's fine if they were, I just think that we should add a note to make clear of what is an acceptable input. WDYT?)

If you see merits to support such cases and/or want to reproduce the message I was returned, here is a publicly available query document embedded in a SOAP envelope I found on this website under 'Response': http://frequentz.com/infocenter/iris/4.4/EPCIS_Query_Web_Service.htm When executing the code, I got the same message as indicated above.

Hope this is helpful.

Kind regards, Ralph

RalphTro commented 1 year ago

Good morning @dakbhavesh , Thanks a lot for your latest updates! All cases I just tested (your original query documents, independently made query documents and frequentz's example) now work, both on my Mac and on my Windows machine. So, happy to merge your PR into our master branch. Ralph