search

RalphTro / epcis-event-hash-generator

ALGORITHM and SOFTWARE PROTOTYPE to uniquely identify/validate the integrity of any EPCIS event through a common, syntax-agnostic approach based on hashing. Takes an EPCIS Document (formatted in either XML or JSON-LD) and returns the corresponding hash value(s).
MIT License
8 stars 4 forks source link

Replace gtin module #97

Closed RalphTro closed 1 year ago

RalphTro commented 1 year ago

Dear @dakbhavesh and @Echsecutor , Happy to report that we might can get rid of our dependency from the gtin package. I basically wrote a new python equivalent of https://github.com/gs1-germany/checkDigitCalculator

In this branch, the issue I reported in https://github.com/RalphTro/epcis-event-hash-generator/issues/87 disappeared when executing the code on my Windows machine.

I am getting a 'Code style workflow run' alert though, and was not able to identify the issue. Would you mind having a look at the possible reason? Feel free to make adjustments and merge it into master once you are satisfied.

Kind regards, Ralph

dakbhavesh commented 1 year ago

Dear @RalphTro, I have addressed the code style issues in dl_normaliser.py.

RalphTro commented 1 year ago

Dear @dakbhavesh , MANY THANKS!