search

RasPlex / OpenPHT

OpenPHT is a community driven fork of Plex Home Theater
Other
596 stars 110 forks source link

Bug: Control over OSD for Paused Player #165

Closed jun6lee closed 1 year ago

jun6lee commented 8 years ago

Behaviour: When you pause a video on OpenPHT, there appears a timeline bar & some operators as part of the OSD (as expected). This gets in the way of my grabbing the exact screenshot I am after from videos. Trying to catch it while it's playing gets a little tedious after numerous rewinds.

Ideal Solution: OSD to disappear after a few seconds of player being paused. This was the case in earlier versions, it got lost somewhere between 1.5.1 and 1.5.2 and has been lost since.

Alternate Solution: Implement a switch, so that the appearance of the OSD is optional for when the player is 'paused'.

A kind soul had implemented this for me in his XBMC Skin before I migrated to Plex: https://github.com/Tgxcorporation/skin.nebula/commit/87b8fa8b9aaf83eb83607e51466d2cd797560ec9

OpenPHT: v1.7.0 Plex Black (though behaviour applies to all skins). Good behaviour lost between 1.5.1 and 1.5.2 PMS: Latest on OSX Sierra

ryanwelka commented 8 years ago

I would second this, as I've tried to take a few screenshots and had the poster/info in my way.

Thanks!

dan-the-man-nz commented 8 years ago

"There's a screenshot button on the OSD in Aeon Nox skin for OpenPHT that clears off all OSD elements and takes a screenshot by itself which is clean and free from junk displayed by the OSD."

maybe you could ask plex black to implement the same thing. or change to Nox. :)

jun6lee commented 8 years ago

@dan-the-man-nz - a plausible solution, if it worked. Using that option in Nox crashes OpenPHT entirely for me, has done as far back as I can recall. Any attempt to take a screenshot with "command + s" also causes a crash. I believe this to be related to something around folders in OSX, this was raised as an enhancement (#95) earlier in the year also.

dan-the-man-nz commented 8 years ago

i just gave this ago on my windows install, no issue, took the clean screenshot for me. so must just be a OSX issue like you said, i suggest posting the logs of it crashing to that thread.

jun6lee commented 7 years ago

Still an issue on 1.8.0

nicolasnoble commented 7 years ago

Couple of comments here: this actually prevents me from reading long subtitles that require pausing if they are scrolling too fast. And on previous versions of OpenPHT, after 1.5.2 made the OSD stick, I used to be able to hide the OSD during pause by pressing the down arrow on my keyboard, but this is no longer the case since a few versions as well.

Even if that's first world problem, this is fairly annoying.

jun6lee commented 7 years ago

@nicolasnoble -- Thanks for bringing this workaround to my attention. Not sure if it's always been there or brought back in a recent update but this now works for me. [on 1.8.0.148-573b6d73]

After hitting pause, if I hit the down arrow, the OSD moves out of visibility giving me the full screen to grab as required. For this reason, I think this can be closed, provided this is the case on windows too. (I'm on OSX Sierra).

I'm still seeing the OSX bug for #95 but a manual screenshot using the OS does the trick.

If somebody with windows can test the workaround works for them too, I'll close this after a confirmation.

enchained commented 7 years ago

I tested 1.8.0.148-573b6d73 on Windows 10 64bit. The down arrow doesn't do anything at all after I hit pause.

In fact, I came here to create an issue about OSD covering the subtitles. I will be really grateful if someone comes along with a solution for Windows. I also thought about an option in the skin settings that moves whole pause OSD bar to the top of the screen as an alternative that won't even require pressing anything and solves the subtitles issue (but doesn't solve the screenshot issue, so maybe worth opening a separate ticket?).

nicolasnoble commented 7 years ago

I just tried it again under Windows 10 on both the stable and pre-release channels, and the down arrow feature on pause is still missing.

If this works under OSX however, and not on Windows, this should clearly be labeled as a bug.

nicolasnoble commented 7 years ago

In fact, reading this code, the OSD is clearly supposed to hide automatically after a little while, so this is clearly broken:

https://github.com/RasPlex/OpenPHT/blob/openpht-1.8/plex/GUI/GUIDialogPlexVideoOSD.cpp#L42

CollinChaffin commented 6 years ago

I agree looking at the code this is not an enhancement as it's been tagged it's flat out a bug and should be addressed as this used to work properly.