bug: Safeguard does not account for patch options

ReVanced / revanced-manager

💊 Application to use ReVanced on Android

https://revanced.app

GNU General Public License v3.0

17.57k stars 726 forks source link

bug: Safeguard does not account for patch options #2053

Open oSumAtrIX opened 2 months ago

oSumAtrIX commented 2 months ago

Bug description

The warning and safeguard should not allow changing options:

But it is still possible to enter and change options:

Acknowledgements

[X] This issue is not a duplicate of an existing bug report.
[X] I have chosen an appropriate title.
[X] All requested information has been provided properly.
[X] The bug is only related to ReVanced Manager

Axelen123 commented 2 months ago

I don't remember why the dialog mentions patch options at all. Why shouldn't the user be allowed to change patch options? Didn't you say that it should be allowed because changing patch options is intended design?

oSumAtrIX commented 2 months ago

Why shouldn't the user be allowed to change patch options

Lets say there's a patch which by default changes the logo. The logo option requires a path to a file. If the user now changes it to something random, the patch would fail. It is encouraged to use the default options unless explicitly confirmed with the user that they don't want that.