ReVanced / revanced-patches

🧩 Patches for ReVanced
https://revanced.app
GNU General Public License v3.0
2.43k stars 281 forks source link

"Integrations have not been merged yet" error #2417

Closed potat-dev closed 2 years ago

potat-dev commented 2 years ago

I get an error when trying to patch:

java -jar revanced-cli-1.4.2-all.jar -a YouTube-17.23.36.apk -c -d ******** -o revanced.apk -b revanced-patches-1.8.0.jar --install
[skipped] amoled: The package version is 17.23.36 and is incompatible.
[skipped] minimized-playback: The package version is 17.23.36 and is incompatible.
[skipped] disable-create-button: The package version is 17.23.36 and is incompatible.
[added] premium-heading
[added] custom-branding
[skipped] disable-shorts-button: The package version is 17.23.36 and is incompatible.
[skipped] disable-fullscreen-panels: The package version is 17.23.36 and is incompatible.
[skipped] old-quality-layout: The package version is 17.23.36 and is incompatible.
[added] hide-cast-button
[skipped] microg-support: Implicitly excluded.
[skipped] general-ads: The package version is 17.23.36 and is incompatible.
[skipped] video-ads: The package version is 17.23.36 and is incompatible.
[skipped] seekbar-tapping: The package version is 17.23.36 and is incompatible.
[skipped] upgrade-button-remover: Incompatible package.
[skipped] tasteBuilder-remover: Incompatible package.
[skipped] background-play: Incompatible package.
[skipped] exclusive-audio-playback: Incompatible package.
[skipped] codecs-unlock: Incompatible package.
[success] premium-heading
[success] custom-branding
[error] hide-cast-button:
app.revanced.patcher.patch.implementation.misc.PatchResultError: hide-cast-button depends on integrations but the following error was raised: Integrations have not been merged yet. This patch can not succeed without the integrations.
        at app.revanced.patcher.Patcher.applyPatch(Patcher.kt:242)
        at app.revanced.patcher.Patcher.applyPatches(Patcher.kt:282)
        at app.revanced.patcher.Patcher.applyPatches$default(Patcher.kt:275)
        at app.revanced.utils.patcher.PatcherKt.applyPatchesVerbose(Patcher.kt:59)
        at app.revanced.cli.patcher.Patcher.start$revanced_cli(Patcher.kt:21)
        at app.revanced.cli.command.MainCommand.run(MainCommand.kt:84)
        at picocli.CommandLine.executeUserObject(CommandLine.java:1939)
        at picocli.CommandLine.access$1300(CommandLine.java:145)
        at picocli.CommandLine$RunLast.executeUserObjectOfLastSubcommandWithSameParent(CommandLine.java:2358)
        at picocli.CommandLine$RunLast.handle(CommandLine.java:2352)
        at picocli.CommandLine$RunLast.handle(CommandLine.java:2314)
        at picocli.CommandLine$AbstractParseResultHandler.execute(CommandLine.java:2179)
        at picocli.CommandLine$RunLast.execute(CommandLine.java:2316)
        at picocli.CommandLine.execute(CommandLine.java:2078)
        at app.revanced.cli.main.MainKt.main(Main.kt:7)

And I don't understand how to fix it

oSumAtrIX commented 2 years ago

hide-cast-button depends on integrations but integrations have not been merged yet. This patch can not succeed without the integrations.

kleinesfilmroellchen commented 1 year ago

hide-cast-button depends on integrations but integrations have not been merged yet. This patch can not succeed without the integrations.

What does this mean? Could you explain how to fix or work around it? Could you reference the issue or pull request that will resolve this if it is a known error?

oSumAtrIX commented 1 year ago

Here is a reference on how to merge integrations.

kleinesfilmroellchen commented 1 year ago

Here is a reference on how to merge integrations.

I have read this document multiple times and it makes one minor passing note about integrations at the very bottom without referencing this error. I did figure it out myself now.

For anyone else encountering this: download the latest integration APK from https://github.com/revanced/revanced-integrations (or any other source that you're using) and supply the path to this APK to the CLI with the "-m" option.

oSumAtrIX commented 1 year ago

The error is a custom one by a patch. The CLI is agnostic to any patch which is why it can't mention this error message. The patch explains that integrations were not merged, which should implicate the need for the opposite.

kleinesfilmroellchen commented 1 year ago

The error is a custom one by a patch. The CLI is agnostic to any patch which is why it can't mention this error message. The patch explains that integrations were not merged, which should implicate the need of the opposite.

That is true, I understand. However, this does not excuse the poor documentation. Frequent issues like this one should be documented with their solutions.

oSumAtrIX commented 1 year ago

The CLI documentation would be in the wrong place as the error is a custom one returned by a patch.