ReVanced / revanced-patches

🧩 Patches for ReVanced
https://revanced.app
GNU General Public License v3.0
2.5k stars 291 forks source link

bug(YouTube): App closes / crashes without any error message #2966

Open rohit04026 opened 7 months ago

rohit04026 commented 7 months ago

Bug description

Running Up to date Revanced patches and the supported app version (19.09.37) [Device-VivoS1 Android-12] The app always closes unexpectedly without any error message after using for some time 3-4 mins, need to reopen the app again. Battery Optimization is disabled in the Revanced GMS settings.

To Reproduce the bug- Use the app for 3-4 mins straight be it shorts or a full length video

The Below video shows the app crash

https://github.com/ReVanced/revanced-patches/assets/151951133/1795d735-b93c-4357-bb9b-39242850ade0

Error logs

No response

Solution

No response

Additional context

No response

Acknowledgements

LisoUseInAIKyrios commented 7 months ago

The debug logs are needed.

Check dontkillmyapp.com for your manufacturer, And ensure you have done all steps needed. Many vendors require multiple steps.

rohit04026 commented 7 months ago

log.txt I have uploaded the log file here, and also checked the website and i think i have done everything right. Still it does crashes everytime i try to use it.

oSumAtrIX commented 7 months ago

The debug logs are 16mb for some reason, did you filter them?

rohit04026 commented 7 months ago

I don't how to filter them, I am new to all this

Morsmalleo commented 7 months ago

I am experiencing this problem as well with YouTube ReVanced Extended v19.07.40

It's only ever started happening since I updated YouTube ReVanced Extended to v19.07.40 using the ReVanced Manager App

It got me to install a new seperate version of microG Service as well before doing this anf ever since then, the microG service that was being utilised before updating YT ReVanced Extended is labelled as "microG (old)", just thought I'd put that out there to just in case.

LisoUseInAIKyrios commented 7 months ago

@Morsmalleo This is not ReVanced extended. Get support from whatever fork you are using.

Morsmalleo commented 7 months ago

Wow cheers buddy, could've been a little bit more polite hey!!

where else am I supposed to go if I can't post it here, it's YouTube ReVanced Extended downloaded using the ReVanced Manager from ReVanced.net, everyone else tells me to post issues related to my problem on this repo, so what the hell am I supposed to do?

Yeah go ahead and mark my comment as off topic but it's not!

On Tue, 2 Apr 2024, 8:22 pm LisoUseInAIKyrios, @.***> wrote:

@Morsmalleo https://github.com/Morsmalleo This is not ReVanced extended. Get support from whatever fork you are using.

— Reply to this email directly, view it on GitHub https://github.com/ReVanced/revanced-patches/issues/2966#issuecomment-2031901080, or unsubscribe https://github.com/notifications/unsubscribe-auth/APK5A2GP62A5AELQHRGC2X3Y3KPJZAVCNFSM6AAAAABFRIRMF2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMZRHEYDCMBYGA . You are receiving this because you were mentioned.Message ID: @.***>

LisoUseInAIKyrios commented 7 months ago

@Morsmalleo ReVanced(.)net is a scam website and not part of the ReVanced project. Change your account passwords because who knows what you are using, and start patching using the manager found at ReVanced.app

Your comments are off topic because neither .net or ReVanced extended is official or part of this project. Stop being sour.

Morsmalleo commented 7 months ago

So after my own checks on the website I mentioned all I have to say is....... F**K SAKES!! Typical!!! Of course the version I'm using is the community ReVanced app which as you've said is not apart of this repo.... Typical it's a f*ing scam, OF COURSE IT IS, WHAT THE FK ISN'T THESE DAYS!!

My bad! My Comments obviously WE'RE off topic so excuse me being a sour little bastard.

LisoUseInAIKyrios commented 7 months ago

The logs don't show any stack trace for any crashes.

The only exception is a security exception that shows up a dozen time or so:

04-01 18:12:47.416 21946 23119 E DatabaseUtils: java.security.AccessControlException: Access not allowed for non-Google app: app.revanced.android.youtube

oSumAtrIX commented 7 months ago

This could be something on the side of GmsCore, since it involves spoofing packages.

LisoUseInAIKyrios commented 7 months ago

Actually, there is a crash stack trace, but it's missing all entries except one line because of the grep command:

04-01 18:12:44.919 25535 25535 W System.err: at app.revanced.integrations.youtube.swipecontrols.SwipeControlsHostActivity.onStart(SwipeControlsHostActivity.kt:77)

@rohit04026 You'll need to do adb logcat > log.txt, then open the log file and search for the section of logs where this occurs then post just that section here. The logs get cleared by the device and only keeps the most recent, so you'll have to reproduce the issue again then logcat and then check the file. You can clear the logs before starting YT using adb logcat -c to keep the logs short and easier to look thru.

You need to search yourself and not send the full logs, because the full logs can include personal data and stuff you should not post to the internet.

LisoUseInAIKyrios commented 7 months ago

@devendrapoonia Google Adb install.

After that follow the instructions for using logcat in my last message.

rohit04026 commented 7 months ago

@LisoUseInAIKyrios I have attached the new log file here, after going through it ,it seems like the problem arises dur to the GMS microG. I uninstalled both the YT and microG(the new one) and reinstalled them ,first microG and then YT. Without signing into the google acc through microG Youtube seems to work fine without crashing so this concludes that the problem is due to microG services not working corrrectly. new_log.txt I have also uploaded the screenshot of the Self-Check section of microG settings Screenshot_2024_0404_163303

LisoUseInAIKyrios commented 7 months ago

The issue probably is not GmsCore MicroG. It probably is an A/B test on your account, and the test is not active when you are not logged in.

LisoUseInAIKyrios commented 7 months ago

@rohit04026 you can also try uninstalling ReVanced YouTube, the patch and install YT 19.03.36 (a fully supported version), and see if that crashes when logged in.

LisoUseInAIKyrios commented 7 months ago

@rohit04026 search your recent device logs and find this statement

app.revanced.integrations.youtube.swipecontrols.SwipeControlsHostActivity.onStart(SwipeControlsHostActivity.kt:77)

Post the section of logs this is found in. The log you just posted does not have this statement, but the fist log does. This is most likely is the crash.

rohit04026 commented 7 months ago

@LisoUseInAIKyrios log_new.txt Here is the new log you asked for, and the above mentioned YT version 19.03.36 seems to work for now, will update if any issues rises.

oSumAtrIX commented 7 months ago

You are using unofficial patches. Capture logs with official patches.

oSumAtrIX commented 7 months ago

You can use ReVanced Manager from here to patch the app with ReVanced Patches following the usage instructions here. For support move to one of our links at https://revanced.app

rohit04026 commented 7 months ago

@LisoUseInAIKyrios log_new.txt Here is the new log you asked for, and the above mentioned YT version 19.03.36 seems to work for now, will update if any issues rises.

Version 19.03.36 also has the same issue after using it for some time and also fails to load thumbnails of videos.

vippium commented 7 months ago

@LisoUseInAIKyrios log_new.txt Here is the new log you asked for, and the above mentioned YT version 19.03.36 seems to work for now, will update if any issues rises.

Version 19.03.36 also has the same issue after using it for some time and also fails to load thumbnails of videos.

This is not YT version nor A/B testing issue...I've already tried it with the v18.45 too. But it is crashing there too...Is the testing also happening on last yr update.?

oSumAtrIX commented 7 months ago

@rohit04026 The statement app.revanced.integrations.youtube.swipecontrols.SwipeControlsHostActivity.onStart(SwipeControlsHostActivity.kt:77) is not present in the logs as asked by @LisoUseInAIKyrios

Follow this and report back:

image

LisoUseInAIKyrios commented 7 months ago

The only exception I see in that log are:

/data/user/0/app.revanced.android.gms/app_cache_dg/9d6eef857cdf684bd532732a23bcd24810523397/libd76E8D98FCF5F.so" already opened by ClassLoader 0x11fb(dalvik.system.DexClassLoader[DexPathList[[zip file "/data/user/0/app.revanced.android.gms/app_cache_dg/9d6eef857cdf684bd532732a23bcd24810523397/the.apk"],nativeLibraryDirectories=[/system/lib64, /system_ext/lib64]]]); can't open in ClassLoader 0x793a41f5cc(dalvik.system.DexClassLoader[DexPathList[[zip file "/data/user/0/app.revanced.android.gms/app_cache_dg/9d6eef857cdf684bd532732a23bcd24810523397/the.apk"],nativeLibraryDirectories=[/system/lib64, /system_ext/lib64]]])
04-04 21:36:25.284 14073 20386 W GmsGuardHandleImpl: Caused by: java.lang.UnsatisfiedLinkError: Shared library "/data/user/0/app.revanced.android.gms/app_cache_dg/9d6eef857cdf684bd532732a23bcd24810523397/libd76E8D98FCF5F.so" already opened by ClassLoader 0x11fb(dalvik.system.DexClassLoader[DexPathList[[zip file "/data/user/0/app.revanced.android.gms/app_cache_dg/9d6eef857cdf684bd532732a23bcd24810523397/the.apk"],nativeLibraryDirectories=[/system/lib64, /system_ext/lib64]]]); can't open in ClassLoader 0x793a41f5cc(dalvik.system.DexClassLoader[DexPathList[[zip file "/data/user/0/app.revanced.android.gms/app_cache_dg/9d6eef857cdf684bd532732a23bcd24810523397/the.apk"],nativeLibraryDirectories=[/system/lib64, /system_ext/lib64]]])

E DatabaseUtils: java.security.AccessControlException: Access not allowed for non-Google app: app.revanced.android.youtube

W WindDownApi: java.lang.SecurityException: Access not allowed for non-Google app: app.revanced.android.youtube

But maybe that's just noise in the logs and not anything of concern.

@devendrapoonia try repatching and excluding patches. Keep repatching and trying the app until only MicroG is selected as described here

oSumAtrIX commented 7 months ago

/data/user/0/app.revanced.android.gms/app_cache_dg/9d6eef857cdf684bd532732a23bcd24810523397/libd76E8D98FCF5F.so" already opened by ClassLoader

This may be an upstream issue where it fails to close a handle.

@devendrapoonia The fork you are using has nothing to do with ReVanced, there is no point arguing using it to reproduce the error. Any issues caused in relation to the fork you will have to forward to the fork.

LisoUseInAIKyrios commented 7 months ago

The log entry looks almost identical to an upstream issue:

https://www.github.com/microg/GmsCore/issues/2153

oSumAtrIX commented 7 months ago

Upstream mentions the following reproduction steps:

1.) Install SPIC - Play Integrity Checker 2.) Check Integrity It works fine for the first time 3) Check Integrity Multiple time. It fails and crash occur internally on adb with error java.lang.UnsatisfiedLinkError Library already loaded in another classloader

Perhaps this can be tested with our fork as well, but it would need a special checker for that purpose.

LisoUseInAIKyrios commented 7 months ago

Could fork it to use MicroG

https://github.com/herzhenr/spic-android

bodabaker commented 7 months ago

Any update on this issue?

shljsl75891 commented 7 months ago

I am also having the same issue. Device: Vivo Z1x Android 11. But, in my other family member's devices, it's not happening as they have more uptodate devices than me.

yakovser commented 7 months ago

similar problem device: Vivo v21e Android 12. Tried different modifications, always crashes in short videos after a little time. From my observations the problem is with people with Vivo phone, maybe the problem is the interaction between rvx and Funtouch OS?

oSumAtrIX commented 7 months ago

The issue is now locked due to spam; regarding the requested information in https://github.com/ReVanced/revanced-patches/issues/2966#issuecomment-2037325513, send an email to osumatrix+revanced-patches/issues/2966@revanced.app with the requested information in https://github.com/ReVanced/revanced-patches/issues/2966#issuecomment-2037325513.